Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3158] Null claim handling #564

Merged
merged 17 commits into from
Mar 25, 2022
Merged

[SDK-3158] Null claim handling #564

merged 17 commits into from
Mar 25, 2022

Commits on Mar 16, 2022

  1. Rename claims -> expectedClaims in verifier for clarity

    @jimmyjames
    jimmyjames committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    d712ddb View commit details
    Browse the repository at this point in the history

  2. added method to validate claim value using predicate 

    TODO:
- Additional tests
- Documentation
- See if there's a better way to run the validations than instanceof checks
- See if we can reuse the new method for the withClaimPresence implementation, instead of the awkwardness we do today (and potentially other areas where we can reuse)
    @jimmyjames
    jimmyjames committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    423a142 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2022

  1. Using Predicates for Verification (#560) 

    * Use predicates for verification

* Code review changes
    @poovamraj
    poovamraj authored Mar 24, 2022
    Configuration menu
    Copy the full SHA
    6794bbc View commit details
    Browse the repository at this point in the history

  2. Add additional tests for predicate based verification

    @poovamraj
    poovamraj committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    4e22222 View commit details
    Browse the repository at this point in the history

  3. Handle claim difference between missing and null

    @poovamraj
    poovamraj committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    634d00a View commit details
    Browse the repository at this point in the history

  4. Verification with null claims

    @poovamraj
    poovamraj committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    478e61f View commit details
    Browse the repository at this point in the history

  5. JWT creation support for null values

    @poovamraj
    poovamraj committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    a1d01fc View commit details
    Browse the repository at this point in the history

  6. Test cases for JWT verification and construction

    @poovamraj
    poovamraj committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    2e75d52 View commit details
    Browse the repository at this point in the history

  7. Add JWT decode test cases

    @poovamraj
    poovamraj committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    c2a46fe View commit details
    Browse the repository at this point in the history

  8. Fix broken tests

    @poovamraj
    poovamraj committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    9955599 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2022

  1. Merge branch 'v4-dev' into predicate-claim-verifier

    @poovamraj
    poovamraj committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    0333526 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'predicate-claim-verifier' into null-claim-handling

    @poovamraj
    poovamraj committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    75ee6a3 View commit details
    Browse the repository at this point in the history

  3. Fixed Lint issues

    @poovamraj
    poovamraj committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    d91c7e0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'predicate-claim-verifier' into null-claim-handling

    @poovamraj
    poovamraj committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    ff2138d View commit details
    Browse the repository at this point in the history

  5. Fixed formatting errors

    @poovamraj
    poovamraj committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    2f1c5df View commit details
    Browse the repository at this point in the history

  6. Add test case to check Claim toString conversion

    @poovamraj
    poovamraj committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    52821a1 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'v4-dev' into null-claim-handling

    @poovamraj
    poovamraj committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    7837e3c View commit details
    Browse the repository at this point in the history