Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3155] Predicate based Claim verification #562

Merged
merged 6 commits into from
Mar 25, 2022
Merged

[SDK-3155] Predicate based Claim verification #562

merged 6 commits into from
Mar 25, 2022

Conversation

poovamraj
Copy link
Contributor

Changes

Testing

  • Added Unit Tests
  • Tests run on all LTS versions
  • DX in Kotlin
JWT.require(algorithm).withClaim("claimName") { claim, _ -> "test" == claim.asString() }
  • This change adds test coverage
  • This change has been tested on the latest version of Java or why not

jimmyjames and others added 4 commits March 16, 2022 10:43
@jimmyjames
Rename claims -> expectedClaims in verifier for clarity
d712ddb
@jimmyjames
added method to validate claim value using predicate
423a142 
TODO:
- Additional tests
- Documentation
- See if there's a better way to run the validations than instanceof checks
- See if we can reuse the new method for the withClaimPresence implementation, instead of the awkwardness we do today (and potentially other areas where we can reuse)
@poovamraj
Using Predicates for Verification (#560)
6794bbc 
* Use predicates for verification

* Code review changes
@poovamraj
Add additional tests for predicate based verification
4e22222
@poovamraj poovamraj added this to the v4-Beta milestone Mar 24, 2022
@poovamraj poovamraj requested a review from a team as a code owner March 24, 2022 10:40
@poovamraj poovamraj requested a review from panga March 24, 2022 10:40
@poovamraj poovamraj mentioned this pull request Mar 24, 2022
Merged
2 tasks
panga
panga previously approved these changes Mar 24, 2022
View reviewed changes
@poovamraj poovamraj requested a review from panga March 25, 2022 09:29
@poovamraj poovamraj merged commit 0029a63 into v4-dev Mar 25, 2022
@poovamraj poovamraj modified the milestones: v4-Beta, 4.0.0-beta.0 May 6, 2022
@poovamraj poovamraj mentioned this pull request May 6, 2022
Merged
@evansims evansims deleted the predicate-claim-verifier branch July 5, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panga panga panga approved these changes

Assignees
No one assigned
Labels
CH: Added review:large Large review
Projects
None yet
Milestone
4.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
3 participants
@poovamraj @panga @jimmyjames