Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing Java LTS versions #536

Merged
merged 5 commits into from
Mar 7, 2022
Merged

Testing Java LTS versions #536

merged 5 commits into from
Mar 7, 2022

Conversation

poovamraj
Copy link
Contributor

Changes

Please describe both what is changing and why this is important. Include:

  • We have added 2 new tasks to run the Unit tests in different JVM LTS versions.
  • Test class compilation will target Java 8 since we run unit tests in Java 8 (Previously this was compiled for Java 11)
  • Jacoco toolVersion is explicitly mentioned since Java 17 is provided only above the specified version
  • Had to ignore Tests for secp256k1 curve since it is disabled for Java 15+. We have to decide on whether we are going to support this and then decide on running these tests

References

Jacoco Release note mentioning Java 17 support - https://www.jacoco.org/jacoco/trunk/doc/changes.html
Java dropping support for secp256k1 curve - https://www.oracle.com/java/technologies/javase/15-relnote-issues.html#JDK-8237219

Testing

  • Ensured the mentioned tasks are running in respective Java LTS versions
  • Ensured the added tasks are run as part of the check task

@poovamraj poovamraj requested a review from a team as a code owner March 4, 2022 11:02
@poovamraj
Copy link
Contributor Author

CI Failure for Java 17 Unit Test task when testing unsupported curve for ECDSA

Screenshot 2022-03-04 at 21 53 45

jimmyjames
jimmyjames suggested changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just requested that you remove the unused Ignore import since we're excluding for java 17 only now.

lib/src/test/java/com/auth0/jwt/JWTCreatorTest.java Outdated Show resolved Hide resolved
lib/src/test/java/com/auth0/jwt/JWTTest.java Outdated Show resolved Hide resolved
lib/src/test/java/com/auth0/jwt/algorithms/ECDSAAlgorithmTest.java Outdated Show resolved Hide resolved
@poovamraj poovamraj merged commit ed91dc6 into v4-dev Mar 7, 2022
@poovamraj poovamraj added this to the v4-Beta milestone Mar 8, 2022
poovamraj added a commit that referenced this pull request Mar 16, 2022
@poovamraj
Testing Java LTS versions (#536)
58c92a8 
* Added Gradle Tasks to run tests on Java LTS versions

* Ignore secp256k1 curve tests

* Removing ignore for tests and checking the CI failure

* Exclude secp256k1 Tests for Java 17

* Remove unwanted "ignore" imports
@poovamraj poovamraj modified the milestones: v4-Beta, 4.0.0-beta.0 May 6, 2022
@poovamraj poovamraj mentioned this pull request May 6, 2022
Merged
@evansims evansims deleted the testing-lts-versions branch July 5, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyjames jimmyjames jimmyjames approved these changes

Assignees
No one assigned
Labels
CH: Added review:medium Medium review
Projects
None yet
Milestone
4.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
2 participants
@poovamraj @jimmyjames