Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3160] Remove internal Clock #533

Merged
merged 1 commit into from
Mar 3, 2022
Merged

[SDK-3160] Remove internal Clock #533

merged 1 commit into from
Mar 3, 2022

Conversation

jimmyjames
Copy link
Contributor

As a follow-up to #532, this change removes the Clock and ClockImpl classes, as well as the tests. java.time.Clock should be used instead when needing to inject a clock for test purposes.

@jimmyjames jimmyjames added this to the v4-Beta milestone Mar 2, 2022
@jimmyjames jimmyjames requested a review from a team as a code owner March 2, 2022 19:08
@jimmyjames
Copy link
Contributor Author

Codecov project check failure is due to removing code and tests.

poovamraj
poovamraj approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@poovamraj poovamraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jimmyjames jimmyjames merged commit 9245f49 into v4-dev Mar 3, 2022
poovamraj pushed a commit that referenced this pull request Mar 16, 2022
@jimmyjames @poovamraj
[SDK-3160] Remove internal Clock (#533)
eefdec8
@jimmyjames jimmyjames deleted the remove-clock branch March 17, 2022 13:11
@poovamraj poovamraj modified the milestones: v4-Beta, 4.0.0-beta.0 May 6, 2022
@poovamraj poovamraj mentioned this pull request May 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poovamraj poovamraj poovamraj approved these changes

Assignees
No one assigned
Labels
CH: Removed review:small Small review
Projects
None yet
Milestone
4.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmyjames @poovamraj