Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#288 changed the signature of
withIssuer(String issuer)
towithIssuer(String... issuer)
. As discussed in #507, this is a binary incompatible change.This change restores that binary compatibility, by introducing a new default method on the
Verification
interface, that simply delegates to the existing implementation.Notes:
apiDiff
check to fail, as the japicmp gradle plugin does not currently support configuring this check (see Support for overrideCompatibilityChangeParameters melix/japicmp-gradle-plugin#43)Verification
interface, which would then never catch any issues, we'll need to bump the baseline compare version when this change is released.JWTVerifierTests
already contain a test that verify the behavior when callingwithIssuer
with a single string.CHANGELOG
for 3.8.0 to indicate the binary incompatible change, and note its fixed version.