Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package-info.java for internal impl package #495

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Add package-info.java for internal impl package #495

merged 2 commits into from
Apr 28, 2021

Conversation

Marcono1234
Copy link
Contributor

Changes

Part of #487 which adds a package-info.java file for the internal impl package, warning users from using classes of the package.
(Additionally adds Eclipse IDE files to .gitignore.)

References

Resolves partially #487

Testing

The genereated Javadoc contains the package documentation:
Javadoc screenshot

Checklist

@Marcono1234 Marcono1234 requested a review from a team as a code owner April 25, 2021 16:31
Copy link
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for the contribution!

@jimmyjames
Copy link
Contributor

closing then will reopen to kick the CI

@jimmyjames jimmyjames closed this Apr 28, 2021
@jimmyjames jimmyjames reopened this Apr 28, 2021
@jimmyjames jimmyjames added CH: Changed documentation This adds, fixes or improves documentation labels Apr 28, 2021
@jimmyjames jimmyjames added this to the v3-Next milestone Apr 28, 2021
@jimmyjames jimmyjames merged commit 283c490 into auth0:master Apr 28, 2021
@Marcono1234 Marcono1234 deleted the marcono1234/impl-javadoc branch April 29, 2021 21:51
@jimmyjames jimmyjames modified the milestones: v3-Next, 3.16.0 May 10, 2021
@jimmyjames jimmyjames mentioned this pull request May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Changed documentation This adds, fixes or improves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants