Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sign/Verify of Long type claims #157

Merged
merged 4 commits into from
Apr 12, 2017
Merged

Conversation

vrancic
Copy link
Contributor

@vrancic vrancic commented Mar 30, 2017

I added Long type for claims and updated tests.

@lbalmaceda
Copy link
Contributor

Hi @vrancic
Thanks for the PR 🎉 ! Before merging it there are a few tests missing I'll need you to add:

  • NullClaim: Test that it returns a null Long. (ref)
  • JWTVerifier: Test that a Long claim can be set and verified (ref) and test that a Long claim has a different value and the exception is raised (ref).

Check the coverage reports if you need more insight.
Cheers.

@vrancic
Copy link
Contributor Author

vrancic commented Apr 4, 2017

Hi @lbalmaceda

All tests are passing now, so I think that this version is ok. If everything is ok, when can I expect the changes to be approved and library added to official maven repository?

Regards

@lbalmaceda
Copy link
Contributor

@vrancic Thanks for the update. Looks good!
I'll be happy to merge the PR but for consistence I think it should also add a method to set a Long claim in the JWTCreator.Builder. Check this as an example and please add the corresponding tests.
Once approved it can take up to 2 weeks for us to publish it.

Cheers

@lbalmaceda lbalmaceda self-requested a review April 7, 2017 17:56
@lbalmaceda lbalmaceda added this to the v3-Next milestone Apr 7, 2017
@lbalmaceda lbalmaceda changed the title Long type is missing for claims. Add Sign/Verify of Long type claims Apr 7, 2017
@lbalmaceda lbalmaceda merged commit 199aca8 into auth0:master Apr 12, 2017
@lbalmaceda lbalmaceda mentioned this pull request Apr 21, 2017
@lbalmaceda lbalmaceda modified the milestones: v3-Next, 3.2.0 May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants