Fail to instantiate validator when audience is an empty string #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
force-pushed
the
patch/improve-audience-error-msg
branch
from
b6e7977 to
059a573
Compare
Widcket
approved these changes
Nov 21, 2022
6 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Checklist
🔧 Changes
An empty audience should never be allowed to be set when the validator gets instantiated.
What happens currently is that if an audience is set as empty on the validator, the validation of the JWT will still fail but only within the request lifecycle.
We're adding the extra len(audience) validation now on the validator so we can fail earlier on app bootstrap in case we pass a nil or empty audience.
📚 References
ValidateWithLeewayin #176 Introduced Breaking Changes to Token Validation #178🔬 Testing