Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isPriority parameter to Log Streams #467

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

duedares-rvj
Copy link
Contributor

🔧 Changes

Added the IsPriority param to the LogStream schema. This brings the SDK in line with present management API.

📚 References

https://auth0.com/docs/api/management/v2/log-streams/post-log-streams

🔬 Testing

Added required param to all test cases and updated recordings.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@duedares-rvj duedares-rvj requested a review from a team as a code owner November 26, 2024 08:29
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.36%. Comparing base (076b6ea) to head (dbd3861).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #467   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files          52       52           
  Lines       10433    10438    +5     
=======================================
+ Hits         9949     9954    +5     
  Misses        366      366           
  Partials      118      118           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@developerkunal developerkunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@developerkunal developerkunal merged commit a74730f into main Nov 27, 2024
7 checks passed
@developerkunal developerkunal deleted the logStreams/update_schema branch November 27, 2024 14:04
@duedares-rvj duedares-rvj self-assigned this Nov 28, 2024
@developerkunal developerkunal mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants