Implement MFA authentication APIs #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
==========================================
- Coverage 95.09% 94.93% -0.16%
==========================================
Files 46 47 +1
Lines 8984 9081 +97
==========================================
+ Hits 8543 8621 +78
- Misses 336 348 +12
- Partials 105 112 +7 ☔ View full report in Codecov by Sentry. |
Widcket
reviewed
Dec 13, 2023
| break | ||
| case params.ClientAssertion != "": | ||
| body.Set("client_assertion", params.ClientAssertion) | ||
| body.Set("client_assertion_type", params.ClientAssertionType) |
There was a problem hiding this comment.
Should we check that params.ClientAssertionType is not empty? Like e.g.
case params.ClientAssertion != "" && params.ClientAssertionType != "":There was a problem hiding this comment.
Yeah that makes sense, will fix
There was a problem hiding this comment.
Added in 716bdad and also took the opportunity to extend addClientAuthenticationToClientAuthStruct to allow specifying if a client secret/client assertion is required
Widcket
reviewed
Dec 13, 2023
Widcket
reviewed
Dec 13, 2023
Widcket
reviewed
Dec 13, 2023
Widcket
reviewed
Dec 13, 2023
Widcket
reviewed
Dec 13, 2023
Widcket
reviewed
Dec 13, 2023
Co-authored-by: Rita Zerrizuela <[email protected]>
Widcket
approved these changes
Dec 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Adds support for the
Challengeand variousVerify*APIs supported by the authentication API.This does not add support for using the Authentication APIs as it was determined that the existing support on the management client is sufficient.
📚 References
Close #316
🔬 Testing
📝 Checklist