Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow client grant scopes to be sent as an empty array #318

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

This PR allows client grant scopes to be sent as an empty array by turning the field into a pointer.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner November 27, 2023 09:48
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9638ef4) 95.18% compared to head (89db961) 95.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   95.18%   95.18%           
=======================================
  Files          46       46           
  Lines        8951     8956    +5     
=======================================
+ Hits         8520     8525    +5     
  Misses        329      329           
  Partials      102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewanharris ewanharris merged commit 9c9892c into main Nov 28, 2023
7 checks passed
@ewanharris ewanharris deleted the allow-grant-scopes-empty-array branch November 28, 2023 14:24
@caleygoff-invitae
Copy link

<3 thank you for merging this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants