Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-218: Allow empty fields through pointers #112

Closed
wants to merge 2 commits into from

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Sep 6, 2022

Description

There are some fields that are unable to be explicitly set to empty when making requests. This occurs with fields that are tagged with omitempty in their struct definitions; the system has no way to differentiate between explicitly empty and omitted. This shortcoming has been frequently logged as an issue in the Terraform provider repo, cataloged here. This PR attempts to completely rectify this inability by setting the field types to pointers. By doing so, we introduce a tertiary state that we can use to distinguish between omitted and explicitly empty values.

⚠️ Note: These changes introduce breaking changes! However, the intention is for this to be one of the last breaking changes before v1.

References

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have read and agreed to the terms within the Auth0 Code of Conduct.
  • I have read the Auth0 General Contribution Guidelines.
  • I have reviewed my own code beforehand.
  • I have added documentation for new/changed functionality in this PR.
  • All active GitHub checks for tests, formatting, and security are passing.
  • The correct base branch is being used, if not main.

@willvedd willvedd closed this Sep 8, 2022
@willvedd willvedd deleted the DXCDT-218-allow-empty-fields-via-pointers branch September 8, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant