Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3717] Add cookie prop to support more express-session stores #395

Merged
merged 2 commits into from
Oct 17, 2022
Merged

[SDK-3717] Add cookie prop to support more express-session stores #395

merged 2 commits into from
Oct 17, 2022

Conversation

adamjmcgrath
Copy link
Contributor

Description

Add cookie.expires and cookie.maxAge to the stored session store session to support express-session stores that rely on this prop. (eg redis-connect)

References

fixes #345

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@adamjmcgrath adamjmcgrath added the review:small Small review label Oct 13, 2022
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner October 13, 2022 18:07
@adamjmcgrath adamjmcgrath changed the title Add cookie prop to support more express-session stores [SDK-3717] Add cookie prop to support more express-session stores Oct 14, 2022
@adamjmcgrath adamjmcgrath merged commit b90c6fe into master Oct 17, 2022
@adamjmcgrath adamjmcgrath deleted the sestion-store-cookie branch October 17, 2022 13:43
@adamjmcgrath adamjmcgrath mentioned this pull request Oct 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
review:small Small review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to set session expiry with express-session-store implementations
2 participants
@adamjmcgrath @stevehobbsdev