Add custom callback handling #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfromaniello @hzalaz - Would be curious to get your feedback on this approach. We want a provide a way to do some additional validation/processing/etc on the callback route before we call the user signed in. |
|
If this example's going to end up in a README please adjust the |
joshcanhelp
changed the title
4 tasks
stevehobbsdev
approved these changes
Dec 13, 2019
jfromaniello
approved these changes
Dec 13, 2019
EXAMPLES.md
Outdated
| handleCallback: async function (req, res, next) { | ||
| const client = req.openid.client; | ||
| try { | ||
| req.session.openidTokens.userinfo = await client.userinfo(req.session.openidTokens); |
There was a problem hiding this comment.
Why storing the userInfo in the TokenSet instead of just in the session?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to do custom callback handling. Used to store/process incoming authorization artifacts or other login-time transactions. See EXAMPLES.md for how to use this option.
Testing
Checklist
master