Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated package.json. async ^1.5.0 #106

Merged
merged 1 commit into from
May 6, 2016

Conversation

ohjimijimijimi
Copy link
Contributor

Hi,
We recently updated express-jwt in our platform and we had some issues with the latest version in conjunction with our test suite (in particular mochajs and supertest).

After some digging we realized the issue was inside the async library. In particular when inside the async.waterfall the async.setImmediate method is called.

We found this issue caolan/async#696.

So, we decided to update async to the latest version and give it a try. Everything worked again.

@janriemer
Copy link

janriemer commented Apr 28, 2016

Hi,
in accordance to this PR, we should consider upgrading async to version 2.0.0 (as of this writing RC3 is the newest). Async v2 comes with functions as individual modules, so we just need to do:
var waterfall = require('async/waterfall').
Any thoughts on this and the referenced PR? I'm wondering, why this PR has been left unanswered for so long. 😧

@jfromaniello
Copy link
Member

Sorry for the delay, async 2 seems to be not released yet.. I will stick with this one.

@jfromaniello jfromaniello merged commit 9199ee1 into auth0:master May 6, 2016
@janriemer
Copy link

Hi @jfromaniello,
OK, nice! Yeah, seems that RC of async 2 will change versions quickly until final release.
I will watch out for the 2.0.0 release and come back here when it is released. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants