Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT override cookie domain option #885

Merged
merged 4 commits into from
Mar 25, 2022

Conversation

Soviut
Copy link
Contributor

@Soviut Soviut commented Mar 11, 2022

Changes

Added an optional cookieDomain setting to the client options that allows the domain set on the cookie to be explicitly set.

This is intended to allow a cookie to work across subdomains by setting it to top-level domain (eg: .example.com).

References

This is intended to solve this issue #884

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@Soviut Soviut requested a review from a team as a code owner March 11, 2022 02:55
Copy link
Contributor

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the contribution. Just left a comment where I think we can expand the docs a bit.

src/global.ts Outdated Show resolved Hide resolved
@stevehobbsdev stevehobbsdev linked an issue Mar 18, 2022 that may be closed by this pull request
@stevehobbsdev stevehobbsdev self-requested a review March 25, 2022 13:41
Copy link
Contributor

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 🎉

@stevehobbsdev stevehobbsdev merged commit defbb63 into auth0:master Mar 25, 2022
@Soviut
Copy link
Contributor Author

Soviut commented Mar 25, 2022

Thanks for all the work reviewing and getting this feature over the line. I'm really excited to put it into practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to override cookie domain
2 participants