Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-1798] prevent unnecessary token requests #525

Merged
merged 2 commits into from
Jul 14, 2020
Merged

[SDK-1798] prevent unnecessary token requests #525

merged 2 commits into from
Jul 14, 2020

Conversation

adamjmcgrath
Copy link
Contributor

Description

Prevents multiple requests when tokens are requested before the first token response (if you're hammering the getTokenSilently button)

References

See #480

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath added small CH: Fixed PR is fixing a bug labels Jul 13, 2020
@adamjmcgrath adamjmcgrath added this to the vNext milestone Jul 13, 2020
@adamjmcgrath adamjmcgrath requested a review from a team July 13, 2020 13:00
stevehobbsdev
stevehobbsdev previously approved these changes Jul 13, 2020
View reviewed changes
@adamjmcgrath
Merge branch 'master' into multiple-token-requests
c6bb4c5 
# Conflicts:
#	src/Auth0Client.ts
@adamjmcgrath adamjmcgrath merged commit 85f995e into master Jul 14, 2020
@adamjmcgrath adamjmcgrath deleted the multiple-token-requests branch July 14, 2020 09:52
@jalovatt jalovatt mentioned this pull request Aug 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
CH: Fixed PR is fixing a bug
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjmcgrath @stevehobbsdev