Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-1308] Return appState value on error from handleRedirectCallback #348

Merged
merged 4 commits into from
Feb 4, 2020
Merged

[SDK-1308] Return appState value on error from handleRedirectCallback #348

merged 4 commits into from
Feb 4, 2020

Conversation

stevehobbsdev
Copy link
Contributor

Description

This PR modifies the behaviour of handleRedirectCallback so that it returns any user-defined appState value in the error when an exception is thrown. This is so that, in the event that an error occurs thanks to a custom rule or similar, the application state can still be retrieved.

References

This has been requested by a customer through an internal service desk ticket.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@stevehobbsdev stevehobbsdev added enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature small CH: Changed PR is changing something labels Feb 4, 2020
@stevehobbsdev stevehobbsdev added this to the vNext milestone Feb 4, 2020
@stevehobbsdev stevehobbsdev requested a review from a team February 4, 2020 12:27
@stevehobbsdev stevehobbsdev self-assigned this Feb 4, 2020
Steve Hobbs added 3 commits February 4, 2020 12:30
Reordered check of transaction vs error
3834ea9
Updated domain for index.html
ea0ae32 
This is why the integration tests are failing, because this page is used
to perform them.
Updated domain name in integration tests
b847cff
@stevehobbsdev stevehobbsdev changed the title Return appState value on error from handleRedirectCallback [SDK-1308] Return appState value on error from handleRedirectCallback Feb 4, 2020
This was referenced Feb 4, 2020
Merged
Merged
@stevehobbsdev stevehobbsdev merged commit a2c94bc into master Feb 4, 2020
@stevehobbsdev stevehobbsdev deleted the fix/appstate-on-error branch February 4, 2020 14:03
This was referenced Mar 9, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees

@stevehobbsdev stevehobbsdev

Labels
CH: Changed PR is changing something enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature
Projects
None yet
Milestone
v1.6.4
Development

Successfully merging this pull request may close these issues.
2 participants
@stevehobbsdev @lbalmaceda