Lazily retrieve transaction from transaction storage #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done to not throw in the Auth0Client constructor when cookies and site data are disabled.
frederikprijck
changed the title
frederikprijck
changed the title
Widcket
approved these changes
Jun 14, 2023
adamjmcgrath
approved these changes
Jun 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When an instance of
Auth0Clientis created, we create an instance of our internalTransactionManager, which instantly accesses the storage.When using
sessionStoragein browsers that have blocked cookies and site data, this will cause an error when calling theAuth0Clientconstructor, resulting in rendering issues in our React wrapper as mentioned here.By lazily accessing the transaction, we avoid this error when the constructor is called, but instead it will throw when the transaction is actually accessed, which will be caught by our React SDK.
References
auth0/auth0-react#540
Checklist