Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect use of SuperTokens' browser-tabs-lock acquireLock function #657

Closed
rishabhpoddar opened this issue Nov 30, 2020 · 0 comments · Fixed by #664
Closed

Incorrect use of SuperTokens' browser-tabs-lock acquireLock function #657

rishabhpoddar opened this issue Nov 30, 2020 · 0 comments · Fixed by #664
Labels
bug report This issue reports a suspect bug or issue with the SDK itself

Comments

@rishabhpoddar
Copy link

Describe the problem

The readme in my lib says that the return of the acquireLock function is a Promise<boolean>. Only if it returns true, should the lock be considered acquired. However, as seen here, the return value is not checked.

More information can be found in this issue, and the changes required can be found in this comment.

@rishabhpoddar rishabhpoddar added the bug report This issue reports a suspect bug or issue with the SDK itself label Nov 30, 2020
@rishabhpoddar rishabhpoddar changed the title Incorrect use of browser-tabs-lock acquireLock function Incorrect use of SuperTokens' browser-tabs-lock acquireLock function Nov 30, 2020
rishabhpoddar added a commit to rishabhpoddar/auth0-spa-js that referenced this issue Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report This issue reports a suspect bug or issue with the SDK itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant