Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3174] Add DELETE method for /api/v2/users/{id}/authenticators endpoint #301

Merged
merged 3 commits into from
Mar 9, 2022
Merged

[SDK-3174] Add DELETE method for /api/v2/users/{id}/authenticators endpoint #301

merged 3 commits into from
Mar 9, 2022

Conversation

akmjenkins
Copy link
Contributor

@akmjenkins akmjenkins commented Jan 18, 2022 •
edited by evansims
Loading

Otherwise, we have to get all enrolments and delete them one by one

Changes

Added a missing method on users from the management api delete_authenticators

References

None, I need this personally.

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@akmjenkins
Add delete authenticators
99b623f 
Otherwise, we have to get all enrolments and delete them one by one
@akmjenkins akmjenkins requested a review from a team as a code owner January 18, 2022 13:35
@evansims evansims changed the title Add delete authenticators [SDK-3174] Add DELETE method for /api/v2/users/{id}/authenticators endpoint Mar 9, 2022
evansims
evansims approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Looks great. I've updated the PR to add test coverage for the changes.

@evansims evansims merged commit fbeab6a into auth0:master Mar 9, 2022
@adamjmcgrath adamjmcgrath added this to the 3.22.0 milestone Mar 22, 2022
@adamjmcgrath adamjmcgrath mentioned this pull request Mar 22, 2022
Merged
@adamjmcgrath adamjmcgrath mentioned this pull request Feb 9, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evansims evansims evansims approved these changes

Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
3.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@akmjenkins @evansims @adamjmcgrath