Add grants, custom domains, rules_configs to API #177
Conversation
…tion and also added a bash script called clean.sh to clean-up any files before a commit. This helps developers like myself to clean things up before requesting a merge
sagnew-dg
changed the title
sagnew-dg
changed the title
There was a problem hiding this comment.
Thanks @sagnew-dg for taking the time to update this up. I've left you a few small comments. Looking forward for your answer.
| return url + '/' + id | ||
| return url | ||
|
|
||
| def all(self, extra_params=None): |
There was a problem hiding this comment.
this endpoint doesn't accept extra params, at least by reading the api explorer. Would you remove it please?
auth0/v3/management/rules_configs.py
Outdated
| return url + '/' + id | ||
| return url | ||
|
|
||
| def all(self, extra_params=None): |
There was a problem hiding this comment.
this endpoint doesn't accept extra params, at least by reading the api explorer. Would you remove it please?
auth0/v3/management/grants.py
Outdated
| to be included in the result, False otherwise. | ||
|
|
||
| extra_params (dictionary, optional): The extra parameters to add to | ||
| the request. The fields, include_fields, page and per_page values |
There was a problem hiding this comment.
The fields, include_fields, page and per_page values should be The page, per_page and include_totals values. Probably copy paste issue.
| the request. The fields, include_fields, page and per_page values | |
| the request. The page, per_page and include_totals values |
| @@ -40,6 +41,7 @@ def __init__(self, domain, token): | |||
| self.logs = Logs(domain, token) | |||
| self.resource_servers = ResourceServers(domain, token) | |||
| self.rules = Rules(domain, token) | |||
| self.rules_configs = RulesConfigs(domain, token) | |||
| self.stats = Stats(domain, token) | |||
There was a problem hiding this comment.
Custom Domains and Grants also should be added here. Please try to keep the alphabetical order 💯
| """Removes the rules config for a given key. | ||
|
|
||
|
|
||
| See: https://auth0.com/docs/api/management/v2#!/Rules_Configs/delete_rules_configs_by_key |
There was a problem hiding this comment.
It's missing the key parameter doc line
| """Sets the rules config for a given key. | ||
|
|
||
|
|
||
| See: https://auth0.com/docs/api/management/v2#!/Rules_Configs/put_rules_configs_by_key |
There was a problem hiding this comment.
It's missing the key and value parameters doc line
| ) | ||
|
|
||
| @mock.patch('auth0.v3.management.rules_configs.RestClient') | ||
| def test_update_factor_providers(self, mock_rc): |
There was a problem hiding this comment.
the name of the test is misleading, please update it
auth0/v3/management/rules_configs.py
Outdated
| } | ||
| return self.client.delete(self._url(), params=params) | ||
|
|
||
| def create(self, key, value): |
There was a problem hiding this comment.
Here's a question for you. What about calling this one "set" and the delete one "unset"? I think it would follow more accordingly the api explorer docs. I tend to relate "create" with POST HTTP method, and this is a PUT sadly. :/
There was a problem hiding this comment.
One of the comments on PR #160 was to name it create, so that's what I started with. I like set / unset better as well because of the HTTP method; I'll change it to that.
…it's a PUT, fix docstrings, remove extra_params where not needed
|
Thanks for the review; latest commit should address the comments. 😀 |
|
Thanks again! I just released 3.6.0 with this changes. |
Following up on #160, I wanted to help get the new APIs listed in the title available in the client. I've addressed the comments I see on that PR and made a few other changes I saw.