Always include Content-Type header in management requests #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
suggested changes
Oct 23, 2018
auth0/v3/management/rest.py
Outdated
| @@ -57,7 +55,6 @@ def post(self, url, data=None): | |||
| headers = self.base_headers.copy() | |||
| headers.update({ | |||
| 'Authorization': 'Bearer %s' % self.jwt, | |||
There was a problem hiding this comment.
it looks like the authorization header is present on all the http methods. I think this one should be part of base headers too
crgk
force-pushed
the
management-content-type-headers
branch
from
2980645 to
3545e39
Compare
|
@crgk please rebase and fix the conflicts. Also change the string formatting to stop using |
crgk
force-pushed
the
management-content-type-headers
branch
from
3545e39 to
647be5a
Compare
|
@lbalmaceda Updated. I only see one other place that was still using % formatting, and it was from my other PR 😬 Should be all sorted out now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on the conversation in #152, this change refactors the
RestClientconstructor so thatbase_headersalways includes the 'Content-Type' header. Tests ensure that the header is included on requests, except forfile_post, which should remove it.