Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish workflow #339

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Fix publish workflow #339

merged 1 commit into from
Nov 10, 2023

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Nov 9, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

This PR fixes the CI publish workflow, as it was failing because the dart-lang/setup-dart/.github/workflows/publish.yml@v1 action installs dependencies using dart pub get, but our packages depend on Flutter, and as such need to use flutter pub get instead:

Screenshot 2023-11-08 at 16 41 53

But still the Dart SDK needs to be installed using that action, as it contains the logic necessary for getting the token used for publishing.

Unlike that action, we're not adding a dry run step because it returns a non-zero error code (that fails the workflow) when there are warnings, and the auth0_flutter package produces warnings:

Screenshot 2023-11-08 at 17 20 54

We won't be fixing the warning marked with red; the scenario the warning is about does not apply for auth0_flutter, which will always depend on a specific version of auth0_flutter_platform_interface.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (253209a) 96.08% compared to head (980ed82) 95.80%.
Report is 22 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #339      +/-   ##
============================================
- Coverage     96.08%   95.80%   -0.29%     
============================================
  Files            97       76      -21     
  Lines          1611     1121     -490     
  Branches        331      281      -50     
============================================
- Hits           1548     1074     -474     
+ Misses           49       46       -3     
+ Partials         14        1      -13     
Flag Coverage Δ
auth0_flutter 100.00% <100.00%> (ø)
auth0_flutter_android ?
auth0_flutter_ios ?
auth0_flutter_platform_interface 87.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lib/src/web/extensions/user_profile_extension.dart 100.00% <100.00%> (ø)
...lutter_platform_interface/lib/src/credentials.dart 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Widcket Widcket merged commit 62f9050 into main Nov 10, 2023
19 checks passed
@Widcket Widcket deleted the chore/fix-publish-workflow branch November 10, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants