Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cli 6 #99

Merged
merged 6 commits into from
Feb 20, 2021
Merged

Cli 6 #99

merged 6 commits into from
Feb 20, 2021

Conversation

bright-poku
Copy link
Contributor

Description

This PR rename clients to apps names in clients.go and added a delete function inside the clients module :

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

cyx
cyx reviewed Feb 19, 2021
View reviewed changes
internal/cli/clients.go Outdated Show resolved Hide resolved
cyx
cyx approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that one minor typo suggestion, otherwise, thanks for doing this! 👍

paddycarey
paddycarey approved these changes Feb 20, 2021
View reviewed changes
Copy link
Contributor

@paddycarey paddycarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! do you think we should rename the files too?

@bright-poku
Copy link
Contributor Author

Looks good! do you think we should rename the files too?

I thought about it too

@bright-poku
Copy link
Contributor Author

Just that one minor typo suggestion, otherwise, thanks for doing this! 👍

committed the suggested changes thanks

@bright-poku bright-poku merged commit f023ec2 into main Feb 20, 2021
@bright-poku bright-poku deleted the CLI-6 branch February 20, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddycarey paddycarey paddycarey approved these changes

@cyx cyx cyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bright-poku @cyx @paddycarey