Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT:596 Add Metadata Flag to Apps #938

Merged
merged 21 commits into from
Dec 7, 2023

Conversation

m3talsmith
Copy link
Contributor

@m3talsmith m3talsmith commented Dec 7, 2023

🔧 Changes

Added flag functionality to add client metatdata to apps create and update.

📚 References

This addresses issue #414 , the main difference being the format of the metadata when passed.

The previous ticket suggested key / value definition as:

--metadata "key" "value"

This may work if it was an array, but Metadata is a map, hence this key / value definition:

--metadata "key=value"

Multiple of the flag or comma delimited values will concatenate into new map key / values. Such that:

  • --metadata "key=value" --metadata "foo=bar"
  • --metadata "key=value,foo=bar"

Create the same map: map[key:value foo:bar].

🔬 Testing

  1. auth0 apps create -n mymetaapp -d mymetaapp -t m2m -r --json --metadata "foo=bar"
  2. View your app metadata on the web portal, in advanced settings
  3. auth0 apps update <app-id> -n mymetaapp -d mymetaapp -t m2m -r --json --metadata "baz=buzz"
  4. View your updated app metadata on the web portal, in advanced settings

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

dependabot bot and others added 11 commits November 13, 2023 12:38
Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](auth0/go-auth0@v1.2.0...v1.3.0)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix: Remove or replace deprecations for GoReleaser config

Remove deprecated replacements
Replace deprecated brews tap
Replace deprecated scoop entries
Fix name_template to reflect exact current naming conventions

* DXCDT-582: Convert audience into a drop down in interactive mode in test token cmd (#906)

Convert audience into a drop down in interactive mode in test token cmd

* Bump github.com/auth0/go-auth0 from 1.2.0 to 1.3.0 (#908)

Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](auth0/go-auth0@v1.2.0...v1.3.0)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Sergiu Ghitea <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…est token cmd (#906)

Convert audience into a drop down in interactive mode in test token cmd

Title Os for final release name fit
Update metadata flag docs for apps create/update
@m3talsmith m3talsmith requested a review from a team as a code owner December 7, 2023 13:52
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (93f54e2) 71.95% compared to head (941b955) 72.00%.

Files Patch % Lines
internal/display/apps.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
+ Coverage   71.95%   72.00%   +0.05%     
==========================================
  Files          92       92              
  Lines       12577    12611      +34     
==========================================
+ Hits         9050     9081      +31     
- Misses       2984     2986       +2     
- Partials      543      544       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/cli/apps.go Outdated Show resolved Hide resolved
internal/cli/apps.go Outdated Show resolved Hide resolved
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small callouts. Also, remember to update the commander integration tests. The existing application commands could be updated and potentially a new case made specifically for metadata.

@m3talsmith m3talsmith enabled auto-merge (squash) December 7, 2023 21:13
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@m3talsmith m3talsmith merged commit 4605fd3 into main Dec 7, 2023
8 checks passed
@m3talsmith m3talsmith deleted the dxcdt-596-add-metadata-flag-to-apps branch December 7, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants