-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DXCDT-601: Supporting multiple identifiers for blocks list and unblock commands #931
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #931 +/- ##
==========================================
+ Coverage 71.90% 71.96% +0.05%
==========================================
Files 92 92
Lines 12566 12577 +11
==========================================
+ Hits 9036 9051 +15
+ Misses 2990 2983 -7
- Partials 540 543 +3 ☔ View full report in Codecov by Sentry. |
…github.com/auth0/auth0-cli into DXCDT-601-users-blocks-support-identifiers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only possible changes that I can see here are maybe adding some error catching (as commented on the lines).
…github.com/auth0/auth0-cli into DXCDT-601-users-blocks-support-identifiers
🔧 Changes
Currently, the
auth0 users blocks list
andauth0 users blocks unblock
commands only support user ID as the identifier. Additional identifiers were requested in #804. To address this request, this PR adds the support for email, username and phone number as identifiers for these commands in addition to the user ID.This
📚 References
Related Issue: #804
🔬 Testing
Adding integration test cases.
📝 Checklist