Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT 586 select multiple ids for delete resource #928

Conversation

m3talsmith
Copy link
Contributor

@m3talsmith m3talsmith commented Nov 30, 2023

🔧 Changes

In all the auth0 * delete|rm commands, we should allow users to select more than one resource to delete to improve DX

📚 References

🔬 Testing

  • Manual integration testing
  • All unit tests are up to date
  • Batch delete commands are used in integration test cleanup

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

dependabot bot and others added 8 commits November 13, 2023 12:38
Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](auth0/go-auth0@v1.2.0...v1.3.0)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix: Remove or replace deprecations for GoReleaser config

Remove deprecated replacements
Replace deprecated brews tap
Replace deprecated scoop entries
Fix name_template to reflect exact current naming conventions

* DXCDT-582: Convert audience into a drop down in interactive mode in test token cmd (auth0#906)

Convert audience into a drop down in interactive mode in test token cmd

* Bump github.com/auth0/go-auth0 from 1.2.0 to 1.3.0 (auth0#908)

Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](auth0/go-auth0@v1.2.0...v1.3.0)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Sergiu Ghitea <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…est token cmd (auth0#906)

Convert audience into a drop down in interactive mode in test token cmd

Title Os for final release name fit
@m3talsmith m3talsmith marked this pull request as ready for review November 30, 2023 20:44
@m3talsmith m3talsmith requested a review from a team as a code owner November 30, 2023 20:44
Added batch deletion to actions command
Added batch deletion to apis command
Added batch deletion to apps command
Added batch deletion to custom domains command
Added batch deletion to log streams command
Added batch deletion for organizations command
Added batch deletion for roles command
Added batch deletion for rules command
Added batch deletion for users non-interactive command
Added batch deletion for user blocks non-interactive command
Update required golang minimum version
@m3talsmith m3talsmith force-pushed the DXCDT-586-select-multiple-ids-for-delete-resource branch 2 times, most recently from 38170cc to d5d9aec Compare December 1, 2023 14:25
@m3talsmith m3talsmith force-pushed the DXCDT-586-select-multiple-ids-for-delete-resource branch from da2b41e to e42a552 Compare December 1, 2023 15:01
Michael Christenson II added 2 commits December 1, 2023 10:04
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good. We can also test by modifying the https://github.com/auth0/auth0-cli/blob/main/test/integration/scripts/test-cleanup.sh file to perform a batch cleanup.

internal/cli/apis.go Outdated Show resolved Hide resolved
internal/cli/actions.go Outdated Show resolved Hide resolved
internal/cli/apis.go Outdated Show resolved Hide resolved
internal/cli/apps.go Outdated Show resolved Hide resolved
internal/cli/apps.go Outdated Show resolved Hide resolved
internal/cli/apps.go Outdated Show resolved Hide resolved
internal/cli/custom_domains.go Outdated Show resolved Hide resolved
internal/cli/input.go Show resolved Hide resolved
internal/cli/log_streams.go Outdated Show resolved Hide resolved
internal/cli/organizations.go Outdated Show resolved Hide resolved
Michael Christenson II added 2 commits December 1, 2023 11:57
Ensure valid id before deletion process
Normalize messages for deletion
Remove unnecessary path escapes
Continue on read failure instead of attempting delete
Inform user of failed id on batch deletion
Only document at most two ids likely
@m3talsmith m3talsmith force-pushed the DXCDT-586-select-multiple-ids-for-delete-resource branch from ce1a060 to e590a59 Compare December 4, 2023 16:30
@m3talsmith m3talsmith closed this Dec 5, 2023
@m3talsmith m3talsmith deleted the DXCDT-586-select-multiple-ids-for-delete-resource branch December 5, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants