DXCDT-600: Show active tenant in auth0 tenants list
#910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willvedd
commented
Nov 13, 2023
| @@ -86,6 +86,7 @@ func buildRootCmd(cli *cli) *cobra.Command { | |||
| PersistentPreRunE: func(cmd *cobra.Command, args []string) error { | |||
| ansi.Initialize(cli.noColor) | |||
| prepareInteractivity(cmd) | |||
| cli.configureRenderer() | |||
There was a problem hiding this comment.
This method mostly serves to attach the active tenant to the renderer struct so that we can make the comparison below. Otherwise, the tenant commands' renderers do not have knowledge of the currently active tenant.
|
Given that there can only be a single active tenant at a time (so only a single |
willvedd
commented
Nov 13, 2023
…h0/auth0-cli into DXCDT-600-show-active-tenant
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #910 +/- ##
==========================================
- Coverage 72.59% 72.58% -0.02%
==========================================
Files 93 93
Lines 12393 12399 +6
==========================================
+ Hits 8997 9000 +3
- Misses 2874 2876 +2
- Partials 522 523 +1
☔ View full report in Codecov by Sentry. |
Widcket
approved these changes
Nov 13, 2023
sergiught
reviewed
Nov 14, 2023
…h0/auth0-cli into DXCDT-600-show-active-tenant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Adds a tabular structure to the
auth0 tenants listcommand including an indicator for the currently active tenant.🔬 Testing
Added slightly stronger assertions to the existing test case.
📝 Checklist