Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set user agent #91

Merged
merged 1 commit into from
Feb 5, 2021
Merged

feat: set user agent #91

merged 1 commit into from
Feb 5, 2021

Conversation

jfatta
Copy link
Contributor

@jfatta jfatta commented Feb 5, 2021

Configure the API client to use the Auth0 CLI User-Agent header. This could help to gather some usage metrics from manage API logs.

@paddycarey
Copy link
Contributor

Can we add a version? could also then use it later for an auth0 --version or similar

@jfatta
Copy link
Contributor Author

jfatta commented Feb 5, 2021

Can we add a version? could also then use it later for an auth0 --version or similar

I think we need to set the version during build/release process. then sending it to the API is easy:

https://github.com/go-auth0/auth0/blob/73c33227fb2fb6488079b964e92caec176ba73bc/management/management.go#L484-L489

can we merge this first only with the user agent?

Copy link
Contributor

@paddycarey paddycarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jfatta jfatta merged commit 83c3010 into main Feb 5, 2021
@jfatta jfatta deleted the feat-set-useragent branch February 5, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants