Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-572: Add ability to fetch all applications in ul customize cmd #886

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Oct 20, 2023

🔧 Changes

Add ability to fetch all applications in ul customize cmd in order to serve the data to the ULP Template https://auth0.com/docs/customize/universal-login-pages/universal-login-page-templates#available-variables.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught marked this pull request as ready for review October 20, 2023 16:51
@sergiught sergiught requested a review from a team as a code owner October 20, 2023 16:51
@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (1088509) 72.42% compared to head (2edb952) 72.46%.

Additional details and impacted files
@@                             Coverage Diff                             @@
##           feature/auth0-universal-login-customize     #886      +/-   ##
===========================================================================
+ Coverage                                    72.42%   72.46%   +0.03%     
===========================================================================
  Files                                           93       93              
  Lines                                        12298    12329      +31     
===========================================================================
+ Hits                                          8907     8934      +27     
- Misses                                        2874     2877       +3     
- Partials                                       517      518       +1     
Files Coverage Δ
internal/cli/universal_login_customize.go 46.08% <88.23%> (+3.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiught sergiught merged commit b1a4528 into feature/auth0-universal-login-customize Oct 23, 2023
6 checks passed
@sergiught sergiught deleted the DXCDT-572-apps branch October 23, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants