Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usernameOnlyPlaceholder from default custom text translations #873

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Remove usernameOnlyPlaceholder from default custom text translations #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/cli/prompts_custom_text.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ func mergeBrandingTextTranslations(
}

for key, text := range translations {
if strings.HasPrefix(key, "error") || strings.HasPrefix(key, "devKeys") {
if strings.HasPrefix(key, "error") || strings.HasPrefix(key, "devKeys") || key == "usernameOnlyPlaceholder" {
continue
}

Expand Down
4 changes: 0 additions & 4 deletions internal/cli/universal_login_customize_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,6 @@ func TestFetchUniversalLoginBrandingData(t *testing.T) {
"signupActionText": "${footerText}",
"title": "Welcome friend, glad to have you!",
"user-blocked": "Your account has been blocked after multiple consecutive login attempts.",
"usernameOnlyPlaceholder": "Username",
"usernamePlaceholder": "Username or email address",
"wrong-credentials": "Wrong username or password",
"wrong-email-credentials": "Wrong email or password",
Expand Down Expand Up @@ -358,7 +357,6 @@ func TestFetchUniversalLoginBrandingData(t *testing.T) {
"signupActionText": "${footerText}",
"title": "Welcome friend, glad to have you!",
"user-blocked": "Your account has been blocked after multiple consecutive login attempts.",
"usernameOnlyPlaceholder": "Username",
"usernamePlaceholder": "Username or email address",
"wrong-credentials": "Wrong username or password",
"wrong-email-credentials": "Wrong email or password",
Expand Down Expand Up @@ -485,7 +483,6 @@ func TestFetchUniversalLoginBrandingData(t *testing.T) {
"signupActionText": "${footerText}",
"title": "Welcome friend, glad to have you!",
"user-blocked": "Your account has been blocked after multiple consecutive login attempts.",
"usernameOnlyPlaceholder": "Username",
"usernamePlaceholder": "Username or email address",
"wrong-credentials": "Wrong username or password",
"wrong-email-credentials": "Wrong email or password",
Expand Down Expand Up @@ -692,7 +689,6 @@ func TestFetchUniversalLoginBrandingData(t *testing.T) {
"signupActionText": "${footerText}",
"title": "Welcome friend, glad to have you!",
"user-blocked": "Your account has been blocked after multiple consecutive login attempts.",
"usernameOnlyPlaceholder": "Username",
"usernamePlaceholder": "Username or email address",
"wrong-credentials": "Wrong username or password",
"wrong-email-credentials": "Wrong email or password",
Expand Down
Loading