Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-549: Add logic to save branding data that gets sent by the web app #872

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Adds logic to save branding that that gets sent by the web app.

📚 References

🔬 Testing

Testing was purposefully omitted as we might encounter a need to further change and refactor some of the code to aid with the integration. They will follow afterwards.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught marked this pull request as ready for review October 10, 2023 14:09
@sergiught sergiught requested a review from a team as a code owner October 10, 2023 14:09
Base automatically changed from DXCDT-564-guard-against-classic-ul to feature/auth0-universal-login-customize October 10, 2023 14:49
@sergiught sergiught force-pushed the DXCDT-549-persist-branding-data branch from b3baf0d to 7433190 Compare October 10, 2023 14:51
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (feature/auth0-universal-login-customize@09b010c). Click here to learn what that means.

Additional details and impacted files
@@                            Coverage Diff                             @@
##             feature/auth0-universal-login-customize     #872   +/-   ##
==========================================================================
  Coverage                                           ?   72.83%           
==========================================================================
  Files                                              ?       93           
  Lines                                              ?    12227           
  Branches                                           ?        0           
==========================================================================
  Hits                                               ?     8906           
  Misses                                             ?     2803           
  Partials                                           ?      518           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sergiught sergiught merged commit 3500101 into feature/auth0-universal-login-customize Oct 10, 2023
6 checks passed
@sergiught sergiught deleted the DXCDT-549-persist-branding-data branch October 10, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants