DXCDT-548: Serve prompt data on demand #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
commented
Oct 6, 2023
| var promptToFetch promptData | ||
| if err := json.Unmarshal(message.Payload, &promptToFetch); err != nil { | ||
| h.display.Errorf("failed to unmarshal %q payload: %v", message.Type, err) | ||
| continue |
There was a problem hiding this comment.
For now opting not to close the connection, but this will most likely be subject to change when we start integrating with the web app in a closer manner.
Widcket
approved these changes
Oct 6, 2023
willvedd
reviewed
Oct 6, 2023
Base automatically changed from
DXCDT-547-websocket-server
to
feature/auth0-universal-login-customize
October 6, 2023 14:46
sergiught
force-pushed
the
DXCDT-548-prompts-on-demand
branch
from
78f61bd to
071b5c2
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/auth0-universal-login-customize #868 +/- ##
==========================================================================
Coverage ? 73.00%
==========================================================================
Files ? 93
Lines ? 12185
Branches ? 0
==========================================================================
Hits ? 8896
Misses ? 2771
Partials ? 518 ☔ View full report in Codecov by Sentry. |
willvedd
approved these changes
Oct 6, 2023
sergiught
merged commit 871ad3b
into
feature/auth0-universal-login-customize
6 checks passed
sergiught
added a commit
that referenced
this pull request
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
In this PR we accept websocket messages sent from the web app to fetch prompt data and serve it back with defaults in, if custom text is not set on them.
📚 References
🔬 Testing
More e2e tests will follow in future PRs.
📝 Checklist