Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing improvements for multiple action secrets, dependencies #852

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Sep 20, 2023

🔧 Changes

As I mentioned in #850, unit tests needed to be added for the case of multiple action dependencies being passed-in. However, like the action secrets, the unit tests were quite flaky because of the non-deterministic sorting of map[string]string data, thereby making assertions more difficult in the tests. To combat this, we're introducing sorting functions to make the tests deterministic and reliable.

📚 References

Related PR: #850

🔬 Testing

All testing changes.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner September 20, 2023 17:38
@willvedd willvedd requested review from sergiught and a team and removed request for a team and sergiught September 20, 2023 17:38
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (6fe8277) 73.36% compared to head (d3cea0d) 73.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #852   +/-   ##
=======================================
  Coverage   73.36%   73.36%           
=======================================
  Files          92       92           
  Lines       11874    11874           
=======================================
  Hits         8711     8711           
  Misses       2647     2647           
  Partials      516      516           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willvedd willvedd enabled auto-merge (squash) September 21, 2023 10:44
@willvedd willvedd merged commit 1b93f15 into main Sep 21, 2023
6 checks passed
@willvedd willvedd deleted the gh-851-multiple-action-dep-unit-testing branch September 21, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants