-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DXCDT-501: auth0 tf generate
end-to-end tests
#848
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…501-tf-generate-e2e-testing
…501-tf-generate-e2e-testing
willvedd
force-pushed
the
DXCDT-501-tf-generate-e2e-testing
branch
from
September 15, 2023 14:42
c5f8e9f
to
9c99f3b
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
==========================================
+ Coverage 72.64% 73.34% +0.69%
==========================================
Files 92 92
Lines 11842 11847 +5
==========================================
+ Hits 8603 8689 +86
+ Misses 2733 2644 -89
- Partials 506 514 +8
☔ View full report in Codecov by Sentry. |
sergiught
approved these changes
Sep 19, 2023
Widcket
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Adding E2E test cases to the
auth0 tf generate
command.Four major cases covered:
One thing to note is that we're reusing the Auth0 CLI client, used for facilitating connection between CLI and tenant for the Terraform provider too. This is not a best practice but a major convenience in testing; preventing us needing to initialize and manage credentials of another client.
🔬 Testing
Four new end-to-end test cases added.
📝 Checklist