Fix actions inputSecretsToActionSecrets
returning duplicates of the last provided secret
#843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Currently, adding multiple secrets only takes into account the last secret provided to the CLI, even though they are all in the map provided by the command.
Looking deeper after printing around a bit, it seemed that the
inputSecretsToActionSecrets
function was the culprit, so I made a very simple change to account for how pointers and loop variables work together.📚 References
I've never used Go so I asked GitHub Copilot for some help, and it did fix the issue after testing it.
🔬 Testing
This is the command I used to test changes:
go run ./cmd/auth0 actions update <action-id> -n pre-user-registration -c "hello" -s "USER_REDIRECT_URL=http://localhost:9000/callback" -s "AGENT_REDIRECT_URL=http://localhost:9000/callback" -s "CUSTOMER_REDIRECT_URL=http://localhost:9000/callback" --json
📝 Checklist