Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-543: Refining tf generate output instructions #842

Merged
merged 10 commits into from
Sep 14, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Sep 13, 2023

🔧 Changes

The auth0 tf generate command is complex and has a few key points of failure. It is paramount that users can be guided through the process. This PR attempts to refine the instructional outputs for clarity and correctness.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner September 13, 2023 02:35
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: +0.18% 🎉

Comparison is base (c39fabf) 72.47% compared to head (a921696) 72.66%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
+ Coverage   72.47%   72.66%   +0.18%     
==========================================
  Files          91       92       +1     
  Lines       11773    11842      +69     
==========================================
+ Hits         8533     8605      +72     
+ Misses       2734     2731       -3     
  Partials      506      506              
Files Changed Coverage Δ
internal/ansi/ansi.go 82.00% <0.00%> (-3.42%) ⬇️
internal/cli/terraform.go 60.91% <0.00%> (+0.58%) ⬆️
internal/cli/actions.go 81.40% <100.00%> (ø)
internal/cli/cli.go 40.78% <100.00%> (-5.64%) ⬇️
internal/cli/management.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/ansi/ansi.go Outdated Show resolved Hide resolved
internal/cli/terraform.go Outdated Show resolved Hide resolved
internal/cli/terraform.go Outdated Show resolved Hide resolved
@willvedd willvedd merged commit 4ad5657 into main Sep 14, 2023
6 checks passed
@willvedd willvedd deleted the DXCDT-543-refine-tf-generate-output-instructions branch September 14, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants