Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-538: Adding progress spinner to tf generate command #838

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Sep 8, 2023

🔧 Changes

The auth0 tf generate command has the potential to take quite a long time. There are two main steps that are the culprits: fetching relevant data from Auth0 and then facilitating the generation/import with Terraform itself. This PR adds two spinners for these two steps to indicate to the user that progress is being made.

🔬 Testing

Manual verification.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner September 8, 2023 21:08
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.05% ⚠️

Comparison is base (da61765) 72.52% compared to head (8e435d6) 72.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
- Coverage   72.52%   72.47%   -0.05%     
==========================================
  Files          91       91              
  Lines       11766    11773       +7     
==========================================
  Hits         8533     8533              
- Misses       2727     2734       +7     
  Partials      506      506              
Files Changed Coverage Δ
internal/cli/terraform.go 60.32% <0.00%> (-1.40%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willvedd willvedd merged commit c39fabf into main Sep 11, 2023
@willvedd willvedd deleted the DXCDT-538-tf-generate-add-loading-spinner branch September 11, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants