Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A0CLI-44] feat: Adding ability for users to pass files as input params in rules commands #83

Merged
merged 1 commit into from
Jan 27, 2021
Merged

[A0CLI-44] feat: Adding ability for users to pass files as input params in rules commands #83

merged 1 commit into from
Jan 27, 2021

Conversation

alexiskulash
Copy link

@alexiskulash alexiskulash commented Jan 27, 2021 •
edited
Loading

zoom_0

Description

Allow users to specify a .js file for script creation/updates

TODOs

  • Better validation of whether user is inputting file vs. string as --script param
  • Fix bug where using tilda in a relative filepath doesn't work (e.g. ~/Downloads/example.js fails)
  • Find out if this could be used elsewhere

@alexiskulash alexiskulash requested a review from cyx January 27, 2021 20:44
@alexiskulash alexiskulash self-assigned this Jan 27, 2021
cyx
cyx approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@alexiskulash alexiskulash merged commit 895677f into main Jan 27, 2021
@alexiskulash alexiskulash deleted the add/user-input-file branch January 27, 2021 21:15
@alexiskulash alexiskulash mentioned this pull request Jan 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyx cyx cyx approved these changes

Assignees

@alexiskulash alexiskulash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexiskulash @cyx