Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A0CLI-38] feat: interactive prompts for actions #76

Merged
merged 4 commits into from
Jan 27, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jan 27, 2021

Description

This PR adds interactive prompts for actions.

Screen.Recording.2021-01-27.at.13.13.17.mov

@Widcket Widcket requested a review from cyx January 27, 2021 16:19
@Widcket Widcket changed the title feat: interactive prompts for actions [A0CLI-38] feat: interactive prompts for actions Jan 27, 2021
@woloski
Copy link

woloski commented Jan 27, 2021

what's the meaning of file and script?

@woloski
Copy link

woloski commented Jan 27, 2021

it's weird to enter the script inline in the param. I would expect this command to create a file with the name of the action slugged. In that file you have the empty template of the action code (a Noop action).

@Widcket
Copy link
Contributor Author

Widcket commented Jan 27, 2021

it's weird to enter the script inline in the param. I would expect this command to create a file with the name of the action slugged. In that file you have the empty template of the action code (a Noop action).

Just added prompts for the existing flags, but I see your point. Maybe we can add a card for that?

Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙇

@cyx
Copy link
Contributor

cyx commented Jan 27, 2021

it's weird to enter the script inline in the param. I would expect this command to create a file with the name of the action slugged. In that file you have the empty template of the action code (a Noop action).

Based on the plans, this command will progressively enhance in the future to take the scaffolding defaults / conventions into account.
For now, we're just opting to specify files and keep the core command simple / stand alone.

@Widcket
Copy link
Contributor Author

Widcket commented Jan 27, 2021

Just removed the inline script prompt (left the flag there) and replaced File with Action File.

@Widcket Widcket merged commit 2a8b23f into main Jan 27, 2021
@Widcket Widcket deleted the feature/interactivity-actions branch January 27, 2021 17:08
@Widcket
Copy link
Contributor Author

Widcket commented Jan 27, 2021

Just added a card to track the suggested improvements: https://auth0team.atlassian.net/browse/A0CLI-56.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants