Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions improvement #73

Merged
merged 12 commits into from
Jan 27, 2021
Merged

Actions improvement #73

merged 12 commits into from
Jan 27, 2021

Conversation

turcottedanny
Copy link
Contributor

@turcottedanny turcottedanny commented Jan 27, 2021

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

  • Improving actions versions command
    image

  • Adding a selector for versions
    image

  • Changed triggers to flows to match terms of the Dashboard
    image
    image

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

internal/cli/actions.go Outdated Show resolved Hide resolved
internal/cli/actions.go Outdated Show resolved Hide resolved
@turcottedanny turcottedanny marked this pull request as ready for review January 27, 2021 18:57
Copy link
Contributor

@iamjem iamjem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@turcottedanny turcottedanny merged commit 730fae8 into main Jan 27, 2021
@turcottedanny turcottedanny deleted the actions-improvement branch January 27, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants