[A0CLI-54] feat: Adding the update rule subcommand #72
+95
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Widcket IIRC you added the interactive prompts, right? Have you done this second bit elsewhere? |
alexiskulash
changed the title
cyx
reviewed
Jan 27, 2021
| }, | ||
| } | ||
|
|
||
| cmd.Flags().StringVarP(&flags.ID, ruleID, "i", "", "ID of the rule to update (required)") |
There was a problem hiding this comment.
Can probably skip the i here, but keep n, s, o, e.
There was a problem hiding this comment.
I left that as i in order to standardize how this was done on L352 -- I'm up for removing the i, but might need to do it in a few spots across the board. Might leave that out of this PR for now, then take a broad sweep later?
cyx
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the base for the
auth0 rules updatesubcommand. Future TODOs include pressingreturn/Enterto skip updating a certain part of the rule (as not all args should be required if I just want to update the rule name, for example).