Miscellaneous test coverage improvements #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
==========================================
+ Coverage 68.60% 69.79% +1.18%
==========================================
Files 87 87
Lines 11239 11192 -47
==========================================
+ Hits 7711 7811 +100
+ Misses 3016 2867 -149
- Partials 512 514 +2
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
sergiught
approved these changes
Apr 11, 2023
Widcket
reviewed
Apr 11, 2023
Widcket
reviewed
Apr 11, 2023
| assert.Len(t, stdout.Bytes(), 0) | ||
| }) | ||
|
|
||
| t.Run("Stream successfully", func(t *testing.T) { |
There was a problem hiding this comment.
Should we have an assert in this test?
There was a problem hiding this comment.
Thanks for spotting that! 👍🏻 Improved in 59e23d8 (#719).
Widcket
approved these changes
Apr 12, 2023
sergiught
force-pushed
the
miscellaneous-test-coverage-improvements
branch
from
59e23d8 to
21e9cf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Numerous unit tests, integration tests, code removal and subtle refactoring to increase the code coverage measurement. These are changes that are too small to exist on their own.
🔬 Testing
All tests pass.
📝 Checklist