Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve codecov setup #678

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Improve codecov setup #678

merged 1 commit into from
Mar 16, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Stabilizes the codecov settings to make them more reliable.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner March 16, 2023 15:54
@@ -93,6 +95,7 @@ jobs:
- name: Update codecov report
uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +1.01 🎉

Comparison is base (23869cf) 50.44% compared to head (d87a704) 51.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
+ Coverage   50.44%   51.46%   +1.01%     
==========================================
  Files          93       93              
  Lines       11771    11771              
==========================================
+ Hits         5938     6058     +120     
+ Misses       5405     5278     -127     
- Partials      428      435       +7     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's reporting a diff compared to an older commit but I'm inclined to chalk that up as an oddity. This PR still provides value as-is.

@sergiught sergiught merged commit d190cd9 into main Mar 16, 2023
@sergiught sergiught deleted the patch/codecov branch March 16, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants