Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A0CLI-48] feat: improve interactivity in APIs and rules #67

Merged
merged 4 commits into from
Jan 27, 2021
Merged

[A0CLI-48] feat: improve interactivity in APIs and rules #67

merged 4 commits into from
Jan 27, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jan 27, 2021

Description

  • Added the global flag --no-input that disables interactivity when passed to any command, as recommended.
  • Ask for interactive input only when in TTY and the flag is not present, as discussed.
  • Preserve flags required status when in non-interactive mode (when interactive, the prompt handles the required status).
  • Added missing prompts

@Widcket Widcket requested a review from cyx January 27, 2021 05:40
@Widcket Widcket changed the title [A0CLI-38] feat: improve interactivity in APIs and rules [A0CLI-48] feat: improve interactivity in APIs and rules Jan 27, 2021
cyx
cyx approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍 💪

@cyx cyx merged commit 3cb6c70 into main Jan 27, 2021
@cyx cyx deleted the feature/interactivity branch January 27, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyx cyx cyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @cyx