Update golangci lint config #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
reviewed
Mar 13, 2023
internal/users/users_embed.go
Outdated
| @@ -5,15 +5,19 @@ import ( | |||
| ) | |||
|
|
|||
| var ( | |||
| // EmptyExample ... | |||
There was a problem hiding this comment.
I was actually thinking about bringing the internal/users package inside the internal/cli/data pkg and then make these private, as they're pretty self explanatory, wdyt?
There was a problem hiding this comment.
I completed the comments for now tho: 014023f (#669).
There was a problem hiding this comment.
I was actually thinking about bringing the internal/users package inside the internal/cli/data pkg and then make these private, as they're pretty self explanatory, wdyt?
Yeah, no need to have them be public.
sergiught
force-pushed
the
patch/fix-linter-settings
branch
from
149995d to
014023f
Compare
willvedd
approved these changes
Mar 13, 2023
Widcket
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
This updates the golangci lint config to stop ignoring all revive issues so we can fix a couple of them. More fix PRs coming soon, trying to keep PRs small.
📚 References
🔬 Testing
📝 Checklist