Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove caster dependency #668

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Remove caster dependency #668

merged 2 commits into from
Mar 13, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Removes the unnecessary caster dependency, as we only need 1 channel with 1 publisher and 1 subscriber to notify of changes within the files.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught marked this pull request as ready for review March 13, 2023 11:43
@sergiught sergiught requested a review from a team as a code owner March 13, 2023 11:43
Base automatically changed from patch/DXCDT-394-ul-preview to main March 13, 2023 12:53
@sergiught sergiught merged commit 3a461c5 into main Mar 13, 2023
@sergiught sergiught deleted the patch/ul-deps-byebye branch March 13, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergiught @Widcket