DXCDT-386: Make api test cases more robust #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
force-pushed
the
DXCDT-386/api-test-cases
branch
from
df0efc4 to
7aa952f
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## DXCDT-386-log-stream-tests #665 +/- ##
==============================================================
+ Coverage 51.12% 51.15% +0.02%
==============================================================
Files 92 92
Lines 11607 11607
==============================================================
+ Hits 5934 5937 +3
+ Misses 5244 5242 -2
+ Partials 429 428 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Widcket
approved these changes
Mar 8, 2023
test/integration/api-test-cases.yaml
Outdated
| json: | ||
| idle_session_lifetime: "72" | ||
|
|
||
| 004 - it fails to use the api command to patch tenant settings with wrong json: |
There was a problem hiding this comment.
Suggested change
| 004 - it fails to use the api command to patch tenant settings with wrong json: | |
| 004 - it fails to use the api command to patch tenant settings with invalid json: |
sergiught
force-pushed
the
DXCDT-386/api-test-cases
branch
from
7aa952f to
b37ebbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
The api command test cases seem to be very flaky due to the big json output and commander having issues parsing it and not finding the right values. In this PR we're leveraging the query parameters to only get back one field and check it for the right value.
📚 References
🔬 Testing
📝 Checklist