Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2/2] DXCDT-291: Update universal login templates update cmd #593

Merged
merged 1 commit into from
Jan 10, 2023
Merged

[2/2] DXCDT-291: Update universal login templates update cmd #593

merged 1 commit into from
Jan 10, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Jan 10, 2023 •
edited
Loading

🔧 Changes

Follow up from: #592.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught force-pushed the patch/DXCDT-291-templates-update-part-2 branch 2 times, most recently from fd5eabd to 1ca427c Compare January 10, 2023 14:50
@sergiught sergiught mentioned this pull request Jan 10, 2023
Merged
2 tasks
@sergiught sergiught marked this pull request as ready for review January 10, 2023 14:59
@sergiught sergiught requested a review from a team as a code owner January 10, 2023 14:59
@sergiught sergiught changed the title DXCDT-291: Update universal login templates update cmd [2/2] DXCDT-291: Update universal login templates update cmd Jan 10, 2023
willvedd
willvedd approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

Base automatically changed from patch/DXCDT-291-deprecate-storybook-part-1 to v1 January 10, 2023 16:31
@sergiught sergiught force-pushed the patch/DXCDT-291-templates-update-part-2 branch from 6c4302d to 54982f4 Compare January 10, 2023 16:33
@sergiught sergiught merged commit 2e53e5c into v1 Jan 10, 2023
@sergiught sergiught deleted the patch/DXCDT-291-templates-update-part-2 branch January 10, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

@willvedd willvedd willvedd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergiught @willvedd @Widcket